Upgrade to PSQL 15.1 #167
Merged
Upgrade to PSQL 15.1 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! |
|
Why |
|
FYI, I almost completed upgrading pglast to this, and everything seems working great! 🎉 |
lfittl
approved these changes
Dec 10, 2022
There was a problem hiding this comment.
Looks good overall!
For the fingerprint tests, can we also add one for MERGE that contains a constant value? Something like this:
MERGE INTO customer_account ca
USING (VALUES (1, 42), (2, 99)) t(customer_id, transaction_value)
ON t.customer_id = ca.customer_id
WHEN MATCHED THEN
UPDATE SET balance = balance + transaction_value + 1
WHEN NOT MATCHED THEN
INSERT (customer_id, balance)
VALUES (t.customer_id, t.transaction_value);This upgrades `libpg_query` to Postgres 15.1. All tests have been updated, and tests were added for new constructs. - `Boolean` nodes have been added to the parser, replacing usage of integers with the values `1`/`0`. - In the postgres parser, `Value` was changed to be a union stored in the `A_Const` type. For this upgrade, we block `A_Const` from code generation, and instead manually implement the relevant required functions. - The `COPY` statement deparser was also updated to attempt deparsing into the old Postgres 8.4-style syntax (e.g. `COPY foo FROM STDIN FREEZE CSV`). This ensures that the regression tests keep working, as new changes in the parse structures mean that these two syntaxes result in equivalent but slightly different parse trees. - Support was added for `MERGE` statements. - Support was added for more advanced publication objects, e.g. `CREATE PUBLICATION foo FOR TABLES IN SCHEMA CURRENT_SCHEMA` - Support was added for `ALTER TABLE ALL IN TABLESPACE ...` statements
This follows the C++ protobuf implementation of JSON generation for consistency.
msepga
force-pushed
the
15-latest-dev
branch
from
901ad3a
to
a1fd904
Compare
lfittl
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
👍 Nicely done, and thanks for adding that extra fingerprint test!
Before merging it would be good to pull in the latest changes from 14-latest (really that should just be #168 which is now merged) - otherwise I think this is good to ship 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
libpg_queryto Postgres 15.1. All tests have been updated, and tests were added for new constructs.Booleannodes have been added to the parser, replacing usage of integers with the values1/0.Valuewas changed to be a union stored in theA_Consttype. For this upgrade, we blockA_Constfrom code generation, and instead manually implement the relevant required functions.COPYstatement deparser was also updated to attempt deparsing into the old Postgres 8.4-style syntax (e.g.COPY foo FROM STDIN FREEZE CSV). This ensures that the regression tests keep working, as new changes in the parse structures mean that these two syntaxes result in equivalent but slightly different parse trees.MERGEstatements.CREATE PUBLICATION foo FOR TABLES IN SCHEMA CURRENT_SCHEMAALTER TABLE ALL IN TABLESPACE ...statements