Fix deparse ALTER TABLE table_name ENABLE TRIGGER ALL syntax errors
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes syntax errors output by parsing/deparsing `ALTER TABLE table_name ENABLE TRIGGER ALL` statements. Previously the deparsed statement would be missing the `ALL` keyword. Looks like the bug was a typo in the deparse logic that caused the `ALL` keyword to be left off. This change adds the `ALL` keyword to the output string when `ENABLE TRIGGER ALL` is used. This change also adds coverage for other forms of `ALTER TABLE` statments that use `ENABLE`/`DISABLE` `TRIGGER`, but the other cases look to already be handled correctly.
|
Good catch - thanks for the contribution! |
lfittl
approved these changes
Nov 29, 2023
CDThomas
added a commit
to cipherstash/pg_query.rs
that referenced
this pull request
Nov 30, 2023
Workaround for using pganalyze/libpg_query#222 until the fix is released in both libpq_query and pg_query.rs.
lelit
added a commit
to lelit/pglast
that referenced
this pull request
Nov 30, 2023
This fixes an issue noticed in pganalyze/libpg_query#222.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes syntax errors output by parsing/deparsing
ALTER TABLE table_name ENABLE TRIGGER ALLstatements. Previously the deparsed statement would be missing theALLkeyword.Looks like the bug was a typo in the deparse logic that caused the
ALLkeyword to be left off.This change adds the
ALLkeyword to the output string whenENABLE TRIGGER ALLis used. This change also adds coverage for other forms ofALTER TABLEstatments that useENABLE/DISABLETRIGGER, but the other cases look to already be handled correctly.