Allow alternate definitions of NAMEDATALEN identifier limit #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR surrounds the definition of the
NAMEDATALEN
constant with an#ifndef
.Why
Increasing
NAMEDATALEN
allows you to, for example, avoid the truncation normally produced by the postgres parser on this 65 character identifier:SELECT aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa12345
Notes
To generate this PR and validate it, I needed to run
make extract_source
.To get
make extract_source
working, I needed these 3 pre-requisites:xcrun
inside ofextract_source.rb
.sed -i ""
invocations peppered throughoutMakefile
(example).3.1.2
.ffi-clang 0.8.0
gem install ffi-clang --version'0.8.0'
ffi-clang
requirement pinned or documented anywhere, but versions offfi-clang
newer than0.8.0
move thevisit_children
method and cause a runtime error inextract_source.rb
: