Stop SpiClient soundness from regressing

.github/workflows/tests.yml

@@ -15,6 +15,7 @@ env:
   # configured by `.cargo/config.toml` on macOS.
   RUST_BACKTRACE: 1
   CARGO_INCREMENTAL: "false"
+  SCCACHE_MAX_FRAME_LENGTH: 100000000
   # CARGO_LOG: cargo::core::compiler::fingerprint=info # Uncomment this to output compiler fingerprint info
 
 jobs:
@@ -25,7 +26,6 @@ jobs:
     env:
       RUSTC_WRAPPER: sccache
       SCCACHE_DIR: /home/runner/.cache/sccache
-      RUSTFLAGS: -Copt-level=0
 
     strategy:
       fail-fast: false
@@ -45,7 +45,6 @@ jobs:
         mv -f sccache-v0.2.15-x86_64-unknown-linux-musl/sccache $HOME/.local/bin/sccache
         chmod +x $HOME/.local/bin/sccache
         echo "$HOME/.local/bin" >> $GITHUB_PATH
-        echo 'SCCACHE_CACHE_SIZE="20G"' >> $GITHUB_ENV
         mkdir -p /home/runner/.cache/sccache
         echo ""
 
@@ -181,6 +180,11 @@ jobs:
           --features "pg$PG_VER" \
           --package pgrx-tests
 
+      # Midway cleanup?
+    - name: Clean up midway checkpoint
+      run: |
+        rm -rf ./target
+
     - name: Run aggregate example tests
       run: cargo test --package aggregate --features "pg$PG_VER" --no-default-features
 
@@ -253,8 +257,11 @@ jobs:
     - name: Run triggers example tests
       run: cargo test --package triggers --features "pg$PG_VER" --no-default-features
 
-#     - name: Run versioned_custom_libname_so example tests
-#       run: cargo test --package versioned_custom_libname_so --features "pg$PG_VER" --no-default-features
+    - name: Run versioned_custom_libname_so example tests
+      run: cargo test --package versioned_custom_libname_so --features "pg$PG_VER" --no-default-features
+
+    - name: Run versioned_so example tests
+      run: cargo test --package versioned_so --features "pg$PG_VER" --no-default-features
 
     # Attempt to make the cache payload slightly smaller.
     - name: Clean up built PGRX files
@@ -281,7 +288,6 @@ jobs:
     env:
       RUSTC_WRAPPER: sccache
       SCCACHE_DIR: /home/runner/.cache/sccache
-      RUSTFLAGS: -Copt-level=0
 
     strategy:
       matrix:
@@ -301,7 +307,6 @@ jobs:
         mv -f sccache-v0.2.15-x86_64-unknown-linux-musl/sccache $HOME/.local/bin/sccache
         chmod +x $HOME/.local/bin/sccache
         echo "$HOME/.local/bin" >> $GITHUB_PATH
-        echo 'SCCACHE_CACHE_SIZE="20G"' >> $GITHUB_ENV
         mkdir -p /home/runner/.cache/sccache
         echo ""
 
@@ -401,7 +406,6 @@ jobs:
     if: "!contains(github.event.head_commit.message, 'nogha')"
     env:
       RUSTC_WRAPPER: sccache
-      SCCACHE_CACHE_SIZE: 20G
       SCCACHE_DIR: /Users/runner/Library/Caches/Mozilla.sccache
       SCCACHE_IDLE_TIMEOUT: 0
 

pgrx-tests/Cargo.toml

@@ -61,6 +61,7 @@ rand = "0.8.5"
 
 [dev-dependencies]
 eyre = "0.6.8"  # testing functions that return `eyre::Result`
+trybuild = "1"
 
 [dependencies.pgrx]
 path = "../pgrx"

pgrx-tests/tests/ui.rs

@@ -0,0 +1,7 @@
+use trybuild::TestCases;
+
+#[test]
+fn ui() {
+    let t = TestCases::new();
+    t.compile_fail("tests/ui/*.rs");
+}

pgrx-tests/tests/ui/escaping-spiclient-1209-cursor.rs

@@ -0,0 +1,27 @@
+use pgrx::prelude::*;
+use std::error::Error;
+
+#[pg_test]
+fn issue1209() -> Result<Option<String>, Box<dyn Error>> {
+    // create the cursor we actually care about
+    let mut res = Spi::connect(|c| {
+        c.open_cursor("select 'hello world' from generate_series(1, 1000)", None)
+            .fetch(1000)
+            .unwrap()
+    });
+
+    // here we just perform some allocations to make sure that the previous cursor gets invalidated
+    for _ in 0..100 {
+        Spi::connect(|c| c.open_cursor("select 1", None).fetch(1).unwrap());
+    }
+
+    // later elements are probably more likely to point to deallocated memory
+    for _ in 0..100 {
+        res.next();
+    }
+
+    // segfault
+    Ok(res.next().unwrap().get::<String>(1)?)
+}
+
+fn main() {}

pgrx-tests/tests/ui/escaping-spiclient-1209-cursor.stderr

@@ -0,0 +1,45 @@
+error: lifetime may not live long enough
+  --> tests/ui/escaping-spiclient-1209-cursor.rs:8:9
+   |
+7  |       let mut res = Spi::connect(|c| {
+   |                                   -- return type of closure is SpiTupleTable<'2>
+   |                                   |
+   |                                   has type `SpiClient<'1>`
+8  | /         c.open_cursor("select 'hello world' from generate_series(1, 1000)", None)
+9  | |             .fetch(1000)
+10 | |             .unwrap()
+   | |_____________________^ returning this value requires that `'1` must outlive `'2`
+
+error[E0515]: cannot return value referencing temporary value
+  --> tests/ui/escaping-spiclient-1209-cursor.rs:8:9
+   |
+8  |           c.open_cursor("select 'hello world' from generate_series(1, 1000)", None)
+   |           ^------------------------------------------------------------------------
+   |           |
+   |  _________temporary value created here
+   | |
+9  | |             .fetch(1000)
+10 | |             .unwrap()
+   | |_____________________^ returns a value referencing data owned by the current function
+   |
+   = help: use `.collect()` to allocate the iterator
+
+error: lifetime may not live long enough
+  --> tests/ui/escaping-spiclient-1209-cursor.rs:15:26
+   |
+15 |         Spi::connect(|c| c.open_cursor("select 1", None).fetch(1).unwrap());
+   |                       -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ returning this value requires that `'1` must outlive `'2`
+   |                       ||
+   |                       |return type of closure is SpiTupleTable<'2>
+   |                       has type `SpiClient<'1>`
+
+error[E0515]: cannot return value referencing temporary value
+  --> tests/ui/escaping-spiclient-1209-cursor.rs:15:26
+   |
+15 |         Spi::connect(|c| c.open_cursor("select 1", None).fetch(1).unwrap());
+   |                          -------------------------------^^^^^^^^^^^^^^^^^^
+   |                          |
+   |                          returns a value referencing data owned by the current function
+   |                          temporary value created here
+   |
+   = help: use `.collect()` to allocate the iterator

pgrx-tests/tests/ui/escaping-spiclient-1209-prep-stmt.rs

@@ -0,0 +1,13 @@
+use pgrx::prelude::*;
+use std::error::Error;
+
+#[pg_extern]
+fn issue1209_prepared_stmt(q: &str) -> Result<Option<String>, Box<dyn Error>> {
+    use pgrx::spi::Query;
+
+    let prepared = { Spi::connect(|c| c.prepare(q, None))? };
+
+    Ok(Spi::connect(|c| prepared.execute(&c, Some(1), None)?.first().get(1))?)
+}
+
+fn main() {}

pgrx-tests/tests/ui/escaping-spiclient-1209-prep-stmt.stderr

@@ -0,0 +1,8 @@
+error: lifetime may not live long enough
+ --> tests/ui/escaping-spiclient-1209-prep-stmt.rs:8:39
+  |
+8 |     let prepared = { Spi::connect(|c| c.prepare(q, None))? };
+  |                                    -- ^^^^^^^^^^^^^^^^^^ returning this value requires that `'1` must outlive `'2`
+  |                                    ||
+  |                                    |return type of closure is std::result::Result<PreparedStatement<'2>, pgrx::spi::SpiError>
+  |                                    has type `SpiClient<'1>`