Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when constructing a new ListCell, the 'next' node begins life as NULL #1285

Merged
merged 1 commit into from
Sep 11, 2023
Merged

when constructing a new ListCell, the 'next' node begins life as NULL #1285

merged 1 commit into from
Sep 11, 2023

Conversation

eeeebbbbrrrr
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr commented Sep 11, 2023 •
edited
Loading

This fixes a segfault when iterating a List.

CI helped to find this when testing #1279 on pg12.

There's still another bug but I haven't found it yet and therefore cannot explain what it is either!

workingjubilee
workingjubilee approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, it's not zero-initialized with MemoryContextAlloc.

@workingjubilee workingjubilee merged commit 7affb12 into pgcentralfoundation:develop Sep 11, 2023
8 checks passed
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeeebbbbrrrr @workingjubilee