fix issue #1301 #1302
Merged
fix issue #1301 #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
approved these changes
Sep 18, 2023
eeeebbbbrrrr
added a commit
that referenced
this pull request
Sep 19, 2023
This fixes issue #1301 such that the schema generator now schema-qualifies the operator name when generating a `CREATE OPERATOR` statement. It also qualifies the associated function. This allows us to pick up the fact that a `#[pg_operator]` annotation was applied to function in a module with `#[pg_schema]`.
Merged
workingjubilee
added a commit
that referenced
this pull request
Sep 19, 2023
Welcome to pgrx v0.10.2! In pgrx v0.10.0, as part of a refactoring step in order to make refactoring easier in the future, without things like losing track of random functions, we... omitted a few functions! These depended on the cshim, but were not direct bindings, themselves. Oops. They're back now in `pgrx::pg_sys`. ## `cargo pgrx` works now for Postgres 16 on macOS Installing extensions on macOS for Postgres 16 had problems due to recent changes to Postgres defaults. We have fixed this and expanded our test coverage for macOS to reduce the odds of this happening in the future, thanks to @bayandin in #1300 ## composites compose better There were some problems with composite types and arrays, and specifically arrays of composite types in composite types. These are the sorts of things that cause edge cases in PgHeapTuple. They should now be appropriately supported, however, thanks to @eeeebbbbrrrr in #1303 ## `#[pg_schema]` will enable your bad ideas The following should now work appropriately: ```rust #[pgrx::pg_schema] mod pg_catalog { ``` It does what you think it does. Since this can affect a global namespace in a way that makes it much easier to conflict with other extensions, it is best to avoid this. However, it is the sort of bad idea that extensions which "take over" the Postgres host extensively redefine the host's capabilities, like https://www.zombodb.com/ does, may have to resort to in order to accomplish their goal. Thanks to @eeeebbbbrrrr in #1302 ## Keep the bug reports coming And thank _you_ for reporting your issues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1301 such that the schema generator now schema-qualifies the operator name when generating a
CREATE OPERATORstatement. It also qualifies the associated function.This allows us to pick up the fact that a
#[pg_operator]annotation was applied to function in a module with#[pg_schema].