Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yeet IntoDatum for u32 #1354

Merged
merged 2 commits into from
Oct 27, 2023
Merged

yeet IntoDatum for u32 #1354

merged 2 commits into from
Oct 27, 2023

Conversation

workingjubilee
Copy link
Member

impl from when pg_sys::Oid was not a newtype but an alias.

now unnecessary.

@workingjubilee
yeet IntoDatum for u32
31950b9 
impl from when `pg_sys::Oid` was not a newtype but an alias.

now unnecessary.
@workingjubilee
Fix doctests that use u32 in Spi
55caa63
@workingjubilee
Copy link
Member Author

Alternatively, we could also implement u{8,16,64}, but I believe we should support those as integers instead of having u32 report OIDOID, and it might surface bugs due to unexpected "overflows" in places.

@workingjubilee workingjubilee merged commit d65300a into pgcentralfoundation:develop Oct 27, 2023
9 checks passed
@workingjubilee workingjubilee deleted the yeet-old-intodatum-for-u32 branch October 28, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

Assignees
No one assigned
Labels
breaks-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@workingjubilee @thomcc