Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow unused_lifetimes for pg_extern. #1655

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: allow unused_lifetimes for pg_extern. #1655

merged 1 commit into from
Apr 15, 2024

Conversation

my-vegetable-has-exploded
Copy link
Contributor

close #1649.

@my-vegetable-has-exploded
allow unused_lifetimes for pg_extern.
e32dc35 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
workingjubilee
workingjubilee approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@workingjubilee workingjubilee merged commit 7c67cf6 into pgcentralfoundation:develop Apr 15, 2024
11 checks passed
@my-vegetable-has-exploded
Copy link
Contributor Author

my-vegetable-has-exploded commented Apr 16, 2024 •
edited
Loading

Thanks! But since I haven’t found where to add tests, the content in this PR don't contain unit tests yet.😂

@workingjubilee
Copy link
Member

It's hard to test "this doesn't emit a warning", we could do it more easily if our trybuild tests were moved to ui_test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Omit lifetime of wrapper function.
2 participants
@my-vegetable-has-exploded @workingjubilee