fix segfault converting a null pg_sys::Datum to a String
#1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
requested changes
Sep 11, 2024
that's why I used the actual issue number! I'll fix it and the description once I see that CI passes. don't worry. ;) |
eeeebbbbrrrr
changed the title
pg_sys::Datum to a String
daamien
pushed a commit
to daamien/pgrx
that referenced
this pull request
Sep 12, 2024
…alfoundation#1853) Looks like this was introduced in beb7901 and we didn't have test coverage around this specific case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1852, which reports a segfault when converting an honestly null
Datuminto aString.Looks like this was introduced in beb7901 and we didn't have test coverage around this specific case.
I quickly audited
src/datum/from.rsand everything else there looks fine.