Blocklist c.h #940
Closed
Blocklist c.h #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This header is used by Postgres, but is not of real use to PGX, as all it does is include various internally-used interfaces. This also reduces about 1MB from the generated symbols.
|
A problem with this is that Not sure we should merge this... |
|
Huh. After generating the bindings for all versions, they continue to include #[repr(C)]
#[derive(Debug, Default)]
pub struct varlena {
pub vl_len_: [::std::os::raw::c_char; 4usize],
pub vl_dat: __IncompleteArrayField<::std::os::raw::c_char>,
}
// more bindings
#[repr(C)]
#[derive(Debug, Copy, Clone)]
pub struct nameData {
pub data: [::std::os::raw::c_char; 64usize],
}Not sure what to make of this, aside from maybe "blocklisting files doesn't work". |
Indeed. Bindgen doesn't really have good ideas about files, sadly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header is used by Postgres, but is not of real use to PGX, as all it does is include various internally-used interfaces. This also reduces about 1MB from the generated symbols.
It seems to work on our tested Linux distros:
https://github.com/tcdi/pgx/actions/runs/3653997966/jobs/6174023739
@thomcc This affects the bindings significantly.