Do not require typarray column when auto-registering extensions #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Feb 14, 2024
| @@ -119,7 +119,7 @@ public Publisher<Void> register(PostgresqlConnection connection, ByteBufAllocato | |||
| } | |||
|
|
|||
| private PostgresqlStatement createQuery(PostgresqlConnection connection) { | |||
| return connection.createStatement(String.format("SELECT oid, typname, typarray FROM pg_catalog.pg_type WHERE typname IN (%s)", getPlaceholders())); | |||
| return connection.createStatement(String.format("SELECT oid, typname, * FROM pg_catalog.pg_type WHERE typname IN (%s)", getPlaceholders())); | |||
There was a problem hiding this comment.
Care to rewrite the SQL into SELECT * as that is a simpler variant?
mp911de
changed the title
mp911de
added a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.