Properly set host header to ascii string in ProxyFixMiddleware. #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with supporting
trusted_cidrs
inProxyFixMiddleware
I noticed that mypy/pyright cannot narrow the type properly when:is used.
After rewriting that to:
I was able to remove the
type: ignore
statements and discovered another bug, namely that the host header is set as a string and not as a bytes object.I think the type narrowing is quite useful here, so maybe we want to keep it? An alternative would be to write it like this:
though that does not end well if another scope type is added in the future.
No strong feeling if you want to keep the
in {}
check instead and ignore the typing, but the host header value should be bytes either way :D