-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request dialog shows white on white text when using dark theme #2592
Comments
This should be better now. Could you confirm @reggatur? This and a few other small dark mode fixes was added. |
Hi Peter,
Yes, dark mode is working great. Thank you.
Another suggestion: Delete:
"and will be in touch with you soon"
from what the Responder sees upon opening the secret link.
The Requestor typically is waiting for a response and is not expecting to have to re-contact the Responder, who, after all, is supposed to respond.
Another suggestion: We Pwpush users are used to links that expire immediately upon opening to prevent attacker-in-the-middle from intercepting an email and opening the link. Can there be an option for the Response to expire immediately upon retrieving it by the Requestor? Now that I think about it, I don't think that is even how it works. Maybe no one can see the Response except the Requestor through the Requestor's account. If that is so, maybe it is worth explaining that somewhere. We users are pretty paranoid about passwords getting exposed. It would be good to be reassured that when someone sends us a password in response to a Request, no one else will be able to see it (without, of course, compromising our computer or our Pwpush account).
Oh, and is there any way for the Requestor to receive an email or a text notification when the Responder has responded, short of opening Pwpush, or maybe if Pwpush is logged in, a desktop or mobile notification? Maybe these are Pro features?
Wells H. Anderson, J.D., CEO
SecureMyFirm Inc.
952.922.1120
https://www.securemyfirm.com
Protecting you from computer disasters
…On Tue, Oct 8, 2024, at 2:37 AM, Peter Giacomo Lombardo wrote:
This should be better now. Could you confirm @reggatur <https://github.com/reggatur>? This and a few other small dark mode fixes was added.
—
Reply to this email directly, view it on GitHub <#2592 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BL4BB6UGCYLMKMWIYNHULBTZ2ODUTAVCNFSM6AAAAABPP6LB6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGA3TQOJQGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This is excellent feedback @reggatur! I'll be following up with this over the weekend and should have some changes out soon. |
Hi @reggatur - late update but email notifications for requests are out - you've probably have already seen this.
This text will be changed soon.
I've filed an issue to better document this and make it a bit clearer. |
Since the original issue is resolved here I'll close this issue out. On the other updates, I'll likely post an update here once the changes go out. Thanks @reggatur! Happy holidays! |
🐛 Bug Report
Request dialog shows white on white text when using dark theme
🔬 How To Reproduce
Steps to reproduce the behavior:
Code sample
Environment
Where are you running/using Password Pusher?
If applicable, what version of Password Pusher?
Screenshots
📈 Expected behavior
📎 Additional context
Brave browser
The text was updated successfully, but these errors were encountered: