Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request dialog shows white on white text when using dark theme #2592

Closed
1 of 21 tasks
reggatur opened this issue Oct 7, 2024 · 5 comments
Closed
1 of 21 tasks

Request dialog shows white on white text when using dark theme #2592

reggatur opened this issue Oct 7, 2024 · 5 comments

Comments

@reggatur
Copy link

reggatur commented Oct 7, 2024

🐛 Bug Report

Request dialog shows white on white text when using dark theme

🔬 How To Reproduce

Steps to reproduce the behavior:

  1. ...

Code sample

Environment

Where are you running/using Password Pusher?

  • pwpush.com
  • Docker Image
    • pwpush
    • Custom image
  • Heroku
  • Digital Ocean
    • App Platform
    • Kubernetes Service
  • Microsoft Azure
    • App Service
    • Container Instances (ACI)
    • Kubernetes Service (AKS)
  • Google Cloud
    • App Engine
    • Cloud Run
    • Kubernetes Engine
  • AWS
    • Elastic Container Service (ECS)
    • Kubernetes Service (AKS)
  • Source Code
  • Other (please specify)

If applicable, what version of Password Pusher?

Screenshots

001590_A4

📈 Expected behavior

📎 Additional context

Brave browser

@pglombardo
Copy link
Owner

This should be better now. Could you confirm @reggatur? This and a few other small dark mode fixes was added.

@reggatur
Copy link
Author

reggatur commented Oct 9, 2024 via email

@pglombardo
Copy link
Owner

This is excellent feedback @reggatur! I'll be following up with this over the weekend and should have some changes out soon.

@pglombardo
Copy link
Owner

Hi @reggatur - late update but email notifications for requests are out - you've probably have already seen this.

"and will be in touch with you soon"

This text will be changed soon.

Maybe no one can see the Response except the Requestor through the Requestor's account. If that is so, maybe it is worth explaining that somewhere.

I've filed an issue to better document this and make it a bit clearer.

@pglombardo
Copy link
Owner

pglombardo commented Dec 21, 2024

Since the original issue is resolved here I'll close this issue out.

On the other updates, I'll likely post an update here once the changes go out.

Thanks @reggatur! Happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants