Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix database service names in docker-compose-xx.yml #2821

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ggruening
Copy link
Contributor

Description

This pull request addresses issues in the docker-compose-mysql.yml and docker-compose-mariadb.yml files related to the naming of the database services. Currently, both the MySQL and MariaDB containers have inconsistent service names. The MySQL container is defined under the service name db, while the application container attempts to connect to it using the name mysql. Similarly, the MariaDB container is also misconfigured. These discrepancies can lead to connection issues, particularly when the stack is integrated into a more complex environment, such as when the container is behind a reverse proxy. Using the correct service names is also a cleaner and more maintainable approach, regardless of the environment in which the stack is deployed.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

After making these changes, I ran the Docker Compose setup and verified that the application can now connect to both the MySQL and MariaDB databases without any issues.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ggruening, thank you for submitting a PR! We will respond as soon as possible.

@pglombardo
Copy link
Owner

Great find thanks @ggruening!

@pglombardo pglombardo merged commit ade8d22 into pglombardo:master Dec 5, 2024
6 checks passed
@ggruening ggruening deleted the fix-service-names branch December 6, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants