Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config setting and add file uploads #752

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

CorentinDeBoisset
Copy link
Contributor

@CorentinDeBoisset CorentinDeBoisset commented Jan 2, 2024

Description

The method to update configuration keys forced a type cast into Boolean for any value, including string keys. This PR removes this cast.

I also added a file-upload feature, and edited tests so that they did not depend on pwpush.com to work (or even be logged in).

Related Issue

#655

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@CorentinDeBoisset CorentinDeBoisset changed the title fix: remove override of the value when setting the config fix config setting and add file uploads Jan 2, 2024
@pglombardo pglombardo added the enhancement New feature or request label Jan 3, 2024
@pglombardo pglombardo merged commit 8917d7e into pglombardo:master Jan 3, 2024
4 checks passed
@pglombardo
Copy link
Owner

Python package 0.10.0 with this fix is out: https://pypi.org/project/pwpush/

@CorentinDeBoisset CorentinDeBoisset deleted the patch-1 branch January 8, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants