Vector not deriving serde::Serialize & serde::Deserialize

[turulix]

As the title says, would it be possible to derive Serialize & Deserialize for the Vector, so you can simply Serialize it into a json string using serde?

[ankane]

Hi @turulix, thanks for the suggestion. I'd like to keep Vector simple (and focused on DB interactions), so think it's better to convert to/from Vec<32> for serialization.

[turulix]

Yes, but this requires a lot of work as a user since you have to manually convert between the Vector type and the Vec. This is a problem when using serde since there is no really clean way of doing this as far as im aware of. And deriving the two traits, this would be done automatically by serde. If you want to keep this simplistic, maybe put this feature behind a feature flag that isn't enabled by default but available as a quality or life feature

[appcypher]

As mentioned above, since pgvector::Vector wraps a Vec<f32>, it is trivial to implement a Serialize/Deserialize behind a serde feature flag.

I mean, this is a datatype fgs. It is not weird to expect that people will want to serialize it.

[turulix]

Made a fork which implements the Serialize & Deserialize in case you need it https://github.com/turulix/pgvector-rust

[appcypher]

Made a fork which implements the Serialize & Deserialize in case you need it https://github.com/turulix/pgvector-rust

Damn! Saw this a little late. I just did the same. Published as pgvec.
I will try to keep as up-to-date as possible but I'm sure these features will be added upstream in the future.

[turulix]

Oh sweet, i'm just gonna use yours then, since I didn't publish mine :)

[ankane]

Added a serde feature in the commit above (will go out with the next release)