Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复bug: 流程图内的链接用新窗口打开命令[blank]无法生效 #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cjb1234567
Copy link

@cjb1234567 cjb1234567 commented Jan 8, 2021

修复bug:
在/document/index?document_id=XX页面打开流程图时, 流程图内的链接用新窗口打开命令[blank]无法生效

例如: markdown流程图代码如下:

st=>start: Start:>http://www.porn-hub.com[blank]
e=>end:>http://www.google.com
op1=>operation: My Operation
sub1=>subroutine: My Subroutine
cond=>condition: Yes
or No?:>http://www.google.com
io=>inputoutput: catch something...
para=>parallel: parallel tasks

st->op1->cond
cond(yes)->io->e
cond(no)->para
para(path1, bottom)->sub1(right)->op1
para(path2, top)->op1 

在以上浏览页面中, Start节点的[blank]会失效,点击不能打开新窗口,而是在当前窗口跳转。 在其他页面可正常打开新窗口。

修复方案: 在/document/index代码中发现所有链接的target都被无脑转成了parent, 在此处添加前置条件show!=new

修复bug: 
在/document/index?document_id=XX页面打开流程图时, 流程图内的链接用新窗口打开命令[blank]无法生效 
 
例如: markdown流程图代码如下:

```flow
st=>start: Start:>http://www.porn-hub.com[blank]
e=>end:>http://www.google.com
op1=>operation: My Operation
sub1=>subroutine: My Subroutine
cond=>condition: Yes
or No?:>http://www.google.com
io=>inputoutput: catch something...
para=>parallel: parallel tasks

st->op1->cond
cond(yes)->io->e
cond(no)->para
para(path1, bottom)->sub1(right)->op1
para(path2, top)->op1 
```
在以上浏览页面中, Start节点的[blank]会失效,点击不能打开新窗口,而是在当前窗口跳转。 在其他页面可正常打开新窗口。
@cjb1234567 cjb1234567 changed the title Update view.html 修复bug: 流程图内的链接用新窗口打开命令[blank]无法生效 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant