Render LEVEL doesn't work correctly

[sraka1]

Phalcon_View::setRenderLevel is broken (for me atleast).

What happens?

$this->view->setRenderLevel(Phalcon_View::LEVEL_ACTION_VIEW);
This prints out the main layout!

What should happen?

Only the view layout should've been printed.

Can anyone replicate this?

EDIT:

JCVD :)

[phalcon]

Yep, render level seems to be wrong, sorry, it will be fixed soon as possible. Thanks for reporting it

[sraka1]

Here's the problem:

/dev/view.c

v4 is the value read from the LEVEL_x_VIEW var

            PHALCON_INIT_VAR(t11);
    ZVAL_LONG(t11, 5);
    PHALCON_INIT_VAR(r24);
    is_smaller_or_equal_function(r24, v4, t11 TSRMLS_CC);
    if (zend_is_true(r24)) {
        PHALCON_ALLOC_ZVAL_MM(r25);
        PHALCON_CONCAT_RIGHT(r25, v2, "index.phtml");
        PHALCON_CPY_WRT(v7, r25);
        if (phalcon_file_exists(v7 TSRMLS_CC) == SUCCESS) {
            PHALCON_CALL_FUNC_NORETURN("ob_clean", 0x013);
            phalcon_require(v7 TSRMLS_CC);
            if (EG(exception) || EG(exit_status) == 255) {
                return;
            }
            PHALCON_ALLOC_ZVAL_MM(r26);
            PHALCON_CALL_FUNC(r26, "ob_get_contents", 0x012);
            phalcon_update_property_zval(this_ptr, "_content", strlen("_content"), r26 TSRMLS_CC);
        }
    }

So what's happening is if LEVEL_x_VIEW is equal or smaller than 5, then render the index.phtml. However, zend_declare_class_constant_long(phalcon_view_class_entry, "LEVEL_ACTION_VIEW", sizeof("LEVEL_ACTION_VIEW")-1, 5 TSRMLS_CC); here we can see that LEVEL_ACTION_VIEW is equal to 5 and this will be rendered. This isn't properly written.

There has to be something that checks "if greater than", if you want to keep your vars untouched.

I'm rewriting it as we speak, however not sure it'll be very good... My C is dodgy and I'm unfamiliar with the entire code... And the PHP magic vars :)

Just my 2 cents.

[phalcon]

Hi JCVD, it was exactly that! It was fixed at dev repository, many thanks!

[sraka1]

Yep, pretty much exactly as mine (by reversing the order of the levels). Will overwrite, I had a extra if statement, yours is great! Thanks for the quick response!