PHP warning fix for the autoLoad() function #12684
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
This small alteration should fix this situation: https://forum.phalconphp.com/discussion/10339/strange-warning-probably-from-zephirfaststrreplace-or-something-
If you have two classes:
My\Class\Foo\Bar
and
My\Class\Foo
When initializing
Foo()
the autoLoad will come to this lineat the moment where
className = "My\Class\Foo"
andnsPrefix = "My\Class\Foo\Bar"
At this point (could be a Zephir bug)
fileName
is something that will makethrow the following warning (Invalid arguments supplied for
str_replace()
). Eithersubstr
is returning something other than an empy string orstr_replace
is not allowing an empy string either way testing iffileName
has any value beforeshould mitigate this warning.
Thanks