Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed _doLowUpdate warning #12739

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Fixed _doLowUpdate warning #12739

merged 1 commit into from
Mar 23, 2017

Conversation

Jurigag
Copy link
Contributor

@Jurigag Jurigag commented Mar 23, 2017 •
edited
Loading

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: when test case like in created tests there is warning happening about wrong type passed to array_merge in _doLowUpdate

Thanks

@Jurigag Jurigag force-pushed the 3.1.x-snapshot-warning branch 4 times, most recently from a92681a to 61f7fee Compare March 23, 2017 15:34
@sergeyklay sergeyklay added this to the 3.1.1 milestone Mar 23, 2017
@sergeyklay sergeyklay merged commit 9ec1056 into phalcon:3.1.x Mar 23, 2017
@sergeyklay
Copy link
Contributor

Thank you

@virgofx
Copy link
Contributor

virgofx commented Mar 23, 2017

👍

@Jurigag Jurigag deleted the 3.1.x-snapshot-warning branch March 27, 2017 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Jurigag @sergeyklay @virgofx