Give different result from Resultset::delete() depending on success #12828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update changelog also and add some simple test. |
sergeyklay
approved these changes
Apr 30, 2017
Jurigag
suggested changes
Apr 30, 2017
|
I've added a message to the changelog but not sure if it's according to the standards that those messages should be. Secondly, I'm not completely sure how to properly create a test for this. Basically if any of the |
Jurigag
reviewed
May 1, 2017
CHANGELOG.md
Outdated
| @@ -22,6 +22,7 @@ | |||
| - Fixed `Phalcon\Mvc\Micro:handle` to correctly handle `before` handlers [#10931](https://github.com/phalcon/cphalcon/pull/10931) | |||
| - Fixed `Phalcon\Mvc\Micro:handle` to correctly handle `afterBinding` handlers | |||
| - Added way to disable setters in `Phalcon\Mvc\Model::assign` by using `Phalcon\Mvc\Model::setup` or ini option | |||
| - Made `Resultset::delete()` return `false` when any of the `Model::delete` calls fails [PR #12828](https://github.com/phalcon/cphalcon/pull/12828) fixing [issue #11133](https://github.com/phalcon/cphalcon/issues/11133) | |||
There was a problem hiding this comment.
No need for link ot pr, just only add issue like other changes aboves. Also without "issue"
|
About test - just return some random false in some of model::delete, then check if result returned by resultset->delete is false. |
|
Just updated CHANGELOG |
sergeyklay
approved these changes
May 13, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Model::delete())In raising this pull request, I confirm the following (please check boxes):
Small description of change: When any
Model::delete()fails the result bubbles to causeResultSet::delete()to returnfalseas well.Thanks