Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Phalcon\Http\Response getStatusCode() to return code only (int) #12916

Merged
merged 3 commits into from
Jun 21, 2017

Conversation

stamster
Copy link
Contributor

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR. (not unit tests but my own code tests)

Small description of change:

Changes wrong behavior of Phalcon\Http\Response getStatusCode() method to return status code only as int instead of full string (see #12895)

Thanks

CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
# [3.2.1](https://github.com/phalcon/cphalcon/releases/tag/v3.2.1) (2017-XX-XX)
- Fixed inconsistent behaviour of `Phalcon\Config::merge` across minor version of PHP7 [#12779](https://github.com/phalcon/cphalcon/issues/12779)
- Fixed visibility of `Phalcon\Mvc\Model\Query\Builder::{_conditionNotIn,_conditionIn,_conditionNotBetween,_conditionBetween}` to allow 3rd party libraries extend it
- Fixed `Phalcon\Http\Response` method `getStatusCode()` to return (int) HTTP code only, instead of full string [#12895]
Copy link
Contributor

@Jurigag Jurigag Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phalcon\Http\Response::getStatusCode and [#12895](https://github.com/phalcon/cphalcon/issues/12895)(missing url part)

@sergeyklay sergeyklay merged commit 5c4b6dc into phalcon:3.2.x Jun 21, 2017
@sergeyklay
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants