Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#16593] - fix: fixed memory leak by anonymous function in PascalCase.zep #16598

Merged
merged 2 commits into from
May 24, 2024
Merged

[#16593] - fix: fixed memory leak by anonymous function in PascalCase.zep #16598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32630bd
[#16593] - fix: fixed memory leak by anonymous function in PascalCase…
noone-silent May 24, 2024
34be74c
Merge branch '5.0.x' into T16593-fix-memory-leak-by-anonymous-function
niden May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG-5.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

### Fixed

- Fixed `Phalcon\Support\Helper\PascalCase` causing memory leak by anonymous function [#16593](https://github.com/phalcon/cphalcon/issues/16593)

### Removed

## [5.7.0](https://github.com/phalcon/cphalcon/releases/tag/v5.7.0) (2024-05-17)
Expand Down
14 changes: 6 additions & 8 deletions phalcon/Support/Helper/Str/PascalCase.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,16 @@ class PascalCase
string text,
string delimiters = null
) -> string {
var exploded, output;
var exploded, output, element;

let exploded = this->processArray(text, delimiters);

let output = array_map(
function (element) {
return ucfirst(mb_strtolower(element));
},
exploded
);
let output = "";
for element in exploded {
let output = output . ucfirst(mb_strtolower(element));
}

return implode("", output);
return output;
}

/**
Expand Down
Loading