Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows batch compatibility #21

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

VincentBlondeau
Copy link

@VincentBlondeau VincentBlondeau commented Nov 25, 2019

This PR aims to add a support for batch (native windows console) for ZeroConf.
The files are still the same but the few lines at the beginning allow to choose between Win and Unix.

Only images >= Pharo7 can be downloaded properly. (I do not plan to implement it for lower versions).

Testing can be done locally with this piece of code:

AbstractZeroConfBashScript compile: 'baseUrl
	^ ''http://localhost:4567/'' asZnUrl'.
ZeroConfCommandLineHandler generateInDirectory: 'GeneratedFiles' asFileReference 
.
server := ZnServer on: 4567.
(staticFileServerDelegate := ZnStaticFileServerDelegate new)
	prefixFromString: ''; 
	directory: 'GeneratedFiles' asFileReference ;
	mimeTypeExpirations: ZnStaticFileServerDelegate defaultMimeTypeExpirations. 
server delegate: staticFileServerDelegate.
server start.

Developed and tested for Windows 10 x64 and Firefox.

@svenvc
Copy link

svenvc commented Nov 26, 2019

Nice and important initiative, I hope you manage to avoid breaking things ..

@VincentBlondeau
Copy link
Author

VincentBlondeau commented Nov 26, 2019

Thanks @svenvc !
I cannot try on all the unix's so if you can test locally it will be great! (and the tests are not running on windows too.....)

@VincentBlondeau
Copy link
Author

I also made a bit of refactoring to use the fileBaseUrl instead of hardcoded values

@VincentBlondeau
Copy link
Author

This PR has not been integrated and is now in conflict with the latest changes... Is there anything blocking this?

@guillep
Copy link
Member

guillep commented May 6, 2021

I'll take a look!!

@VincentBlondeau
Copy link
Author

Is it possible to have this PR fixed for Pharo 10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants