Forbid to have an extension method in the package owning the class #14354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently possible to have a method that is an extension method that is in the same package as its class. This creates weird behaviors were some tools consider it an extension method and some other consider it not an extension method. To make thing more coherent I propose that we forbid to have this by classifying such methods under the unclassified protocol instead.
tesonep
requested changes
Jul 24, 2023
|
Apparently the warning is preventing the bootstrap to finish. Do you know what I should do so that it just log the problem and proceed? |
jecisc
added
the
Status: Need more work
|
Checking the code of the compiler it seems that the right way would be to use a Notification or even a SystemNotification instead of a warning |
jecisc
removed
the
Status: Need more work
|
The build now passes and things are working correctly. In the non interactive environment things get logged. |
|
The last failure is fixed by this: pillar-markup/Microdown#658 But I need someone with merge rights :'( |
|
The requested changes were applied and the tests are now green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently possible to have a method that is an extension method that is in the same package as its class. This creates weird behaviors were some tools consider it an extension method and some other consider it not an extension method.
To make thing more coherent I propose that we forbid to have this by classifying such methods under the unclassified protocol instead.
Fixes ##14353