Fixes send selection and adds a send link and send page context option #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phaux
requested changes
Mar 12, 2021
|
I just committed my first go at a page action and popup. It's a little rough but can be improved upon If a user only has one telegram channel added, the page action will immediately send the page to that channel when clicked. Otherwise, the popup gives them a dropdown list to which a user can choose where to send the page to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not too savvy with the telegram API(or js really) but from my research, it seems
sendMediaGroupis used for groups of media like pictures and video however in the selection context only text would be available (afaik).I believe this was causing the send selection option to fail. I've switched it to use the selected text and the sendMessage method for now.
I've also added a send link option for when a user right clicks a link and a send page option for when a user right clicks the page.
let me know what you think!