Merge branch 'master' of https://github.com/phaverty/RLEVectors.jl

README.md

@@ -10,7 +10,7 @@ is useful to know the bounds of genome regions covered by these runs,
 the values associated with these runs, and to be able to perform
 various mathematical operations on these values.
 
-[![Build Status](https://travis-ci.org/phaverty/RLEVectors.jl.svg?branch=master)](https://travis-ci.org/phaverty/RLEVectors.jl)
+[![Build Status](https://travis-ci.com/phaverty/RLEVectors.jl.svg?branch=master)](https://travis-ci.com/phaverty/RLEVectors.jl)
 [![Coverage Status](https://codecov.io/github/phaverty/RLEVectors.jl/coverage.svg?branch=master)](https://codecov.io/github/phaverty/RLEVectors.jl?branch=master)
 
 [![](https://img.shields.io/badge/docs-latest-blue.svg)](https://phaverty.github.io/RLEVectors.jl/latest)

src/indexing.jl

@@ -73,7 +73,6 @@ function Base.setindex!(rle::RLEVector, value, i::Integer)
     run = ind2run(rle, i)
     runvalue = rle.runvalues[run]
     runend = rle.runends[run]
-    #value == runvalue && return rle # replace with same value, no-op
     isequal(value, runvalue) && return rle
     previous_run = run - 1
     next_run = run + 1
@@ -148,6 +147,12 @@ function Base.getindex(x::RLEVector, i::AbstractVector{<:Int})
     RLEVector(x.runvalues[run_indices])
 end
 
+function Base.getindex(x::RLEVector, i::AbstractVector{Bool})
+    # FIXME: room for optimization for runs of true
+    new_inds = findall(i)
+    x[new_inds]
+end
+
 function Base.setindex!(x::RLEVector, value::AbstractVector, indices::UnitRange)
     setindex!(x, RLEVector(value), indices)
 end

test/test_indexing.jl

@@ -36,6 +36,8 @@ using RLEVectors
     ## getindex with logical
     x = RLEVector([1, 2], [2, 4])
     @test x[[true, false, false, true]] == RLEVector([1, 2])
+    x = RLEVector(["a","a","b","c"])
+    @test x[[true,false,true,false]] == RLEVector(["a","b"])
 
     ## setindex! for single position
     y = RLEVector([3, 4, 4, 5, 5])