Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getindex logical vector, fixes #44 #47

Merged
merged 4 commits into from
Dec 31, 2020
Merged

Conversation

phaverty
Copy link
Owner

add getindex method for Vector{Bool} indices, fixes indexing into RLEVector of strings using vector of bools

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #47 (124938b) into master (e218d67) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   92.04%   92.06%   +0.02%     
==========================================
  Files          15       15              
  Lines         729      731       +2     
==========================================
+ Hits          671      673       +2     
  Misses         58       58              
Impacted Files Coverage Δ
src/indexing.jl 91.46% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e218d67...124938b. Read the comment docs.

@phaverty phaverty merged commit 452062b into master Dec 31, 2020
@phaverty phaverty deleted the getindex_logical_vector branch December 31, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant