Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeCode missing after AdditionalReferencedDocument conversion #18

Closed
L3Mars opened this issue Dec 15, 2022 · 4 comments
Closed

TypeCode missing after AdditionalReferencedDocument conversion #18

L3Mars opened this issue Dec 15, 2022 · 4 comments
Assignees
@phax
Labels
bug Something isn't working

Comments

@L3Mars
Copy link

L3Mars commented Dec 15, 2022

There seems to be a problem converting the AdditionalReferencedDocument field to cac:DocumentReference, the TypeCode is missing on the output xml.

// Input CII
<am:ApplicableHeaderTradeAgreement>
...
	<ram:AdditionalReferencedDocument>
		<ram:IssuerAssignedID schemeID="AAJ">18088852:20221215</ram:IssuerAssignedID>
		<ram:TypeCode>130</ram:TypeCode>
	</ram:AdditionalReferencedDocument>
...
</ram:ApplicableHeaderTradeAgreement>
// Output UBL
<cac:InvoiceLine>
...
  <cac:DocumentReference>
	  <cbc:ID>18088852:20221215</cbc:ID>
  </cac:DocumentReference>
...
</cac:InvoiceLine>
@phax phax self-assigned this Dec 15, 2022
@phax phax added the bug Something isn't working label Dec 15, 2022
@phax
Copy link
Owner

phax commented Dec 15, 2022 •
edited
Loading

Mapping the CII TypeCode to UBL DocumentTypeCode
But only if the value is either 50 (BT-17) or 130 (BT-18).

Other values are explicitly forbidden and checked by the EN-16931 validation artefacts.

phax added a commit that referenced this issue Dec 15, 2022
@phax
Taking over TypeCode for additional references; #18
42a952e
@phax
Copy link
Owner

phax commented Dec 15, 2022

@L3Mars if that suits you, I will release v1.4.10 immediately.

@L3Mars
Copy link
Author

L3Mars commented Dec 16, 2022

@phax That would be great, thank you !

@phax
Copy link
Owner

phax commented Dec 16, 2022

Release 1.4.10 is out. Thanks for reporting

@phax phax closed this as completed Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phax @L3Mars