chore: fix SA

pheanstalk · Dec 5, 2022 · 6745126 · 6745126
1 parent 6ebc085
commit 6745126
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/tests/Integration/Examples/PublisherTest.php b/tests/Integration/Examples/PublisherTest.php
@@ -15,8 +15,8 @@ final class PublisherTest extends TestCase
      */
     public function testPublishJob(): void
     {
-        if (empty(SERVER_HOST)) {
-            $this->markTestSkipped('No SERVER_HOST configured');
+        if (SERVER_HOST === '') {
+            self::markTestSkipped('No SERVER_HOST configured');
         }
         $pheanstalk = PheanstalkPublisher::create(SERVER_HOST);
 

diff --git a/tests/Integration/PheanstalkTest.php b/tests/Integration/PheanstalkTest.php
@@ -388,12 +388,12 @@ public function testKickKicksDelayedJobWhenNoJobsAreBuried(): void
     final protected function getHost(): string
     {
         if (str_contains(static::class, "Unix")) {
-            if (empty(UNIX_SERVER_HOST)) {
-                $this->markTestSkipped('No Unix socket configured via UNIX_SERVER_HOST');
+            if (UNIX_SERVER_HOST === '') {
+                self::markTestSkipped('No Unix socket configured via UNIX_SERVER_HOST');
             }
             return UNIX_SERVER_HOST;
-        } elseif (empty(SERVER_HOST)) {
-            $this->markTestSkipped('No server host configured via SERVER_HOST');
+        } elseif (SERVER_HOST === '') {
+            self::markTestSkipped('No server host configured via SERVER_HOST');
         }
         return SERVER_HOST;
     }

diff --git a/tests/Integration/SocketFactoryTest.php b/tests/Integration/SocketFactoryTest.php
@@ -30,15 +30,15 @@ final class SocketFactoryTest extends TestCase
      */
     public function factoryProvider(): iterable
     {
-        if (!empty(SERVER_HOST)) {
+        if (SERVER_HOST !== '') {
             yield [new SocketFactory(SERVER_HOST, implementation: SocketImplementation::SOCKET), SocketSocket::class];
             yield [new SocketFactory(SERVER_HOST, implementation: SocketImplementation::STREAM), StreamSocket::class];
             yield [
                 new SocketFactory(SERVER_HOST, implementation: SocketImplementation::FSOCKOPEN),
                 FsockopenSocket::class
             ];
         }
-        if (!empty(UNIX_SERVER_HOST)) {
+        if (UNIX_SERVER_HOST !== '') {
             yield [
                 new SocketFactory(UNIX_SERVER_HOST, implementation: SocketImplementation::SOCKET),
                 SocketSocket::class