Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y Semantics for bottom bar in single and multi-screen sims #94

Closed
terracoda opened this issue Mar 16, 2018 · 16 comments
Closed

A11y Semantics for bottom bar in single and multi-screen sims #94

terracoda opened this issue Mar 16, 2018 · 16 comments

Comments

@terracoda
Copy link
Contributor

See #25 for historical discussion.

In March 6th Keyboard Nav Meeting, we decided to re-structure the bottom bar to better communicate the function/role of the bottom bar and to better communicate access to sim screen buttons in multi-screen sims.

@terracoda will post new HTML here and we can discuss any further code or design changes here.

@terracoda
Copy link
Contributor Author

terracoda commented Mar 16, 2018

Using Build and Atom as an Example:

@terracoda
Copy link
Contributor Author

terracoda commented Mar 16, 2018

I updated the actual template files.
Will add 2 more examples to see what semantics we hear on the phet menu items.

Note added June 20: I am not adding any more examples. The multi-screen sim example is being reviewed.

@terracoda
Copy link
Contributor Author

terracoda commented Jun 1, 2018

Adding links to the template files:
Template Example:

@terracoda
Copy link
Contributor Author

I have created a Design Pattern for multi-screen sims in joist. I used code from these mock-ups buyt have iterated a little bit.
I will update these mock-ups once the design patterns is ok'd by the team.

@terracoda
Copy link
Contributor Author

Mark down file for the Home Screen is in joist/doc/HomeScreen.md

@terracoda
Copy link
Contributor Author

terracoda commented Jun 20, 2018

@zepumph, I have updated the index.html file in the baa-screens folder. I have put all the sim content on one page, so everything can be seen together.

FYI, I put horizontal rules in between sim screen.

Note that the code validates with warnings about the multiple H1 elements, and the JS that is supposed to collapse and expand the PhET Menu is not quite right. I'm not sure why it works for one button, but not the other.

@terracoda
Copy link
Contributor Author

When on git hub, the javascript for the PhET Menu does not work on either PhET Menu button.

@terracoda
Copy link
Contributor Author

The example in #94 (comment) is updated, and awaiting review by team.

terracoda added a commit that referenced this issue Jun 21, 2018
…. PhET Menu works locally. Related issue #94, #104, #112, and more.
terracoda added a commit that referenced this issue Jun 21, 2018
…HTML. PhET Menu works locally on first button. Cleanup related to issues #94, #104, #112, and more.
@terracoda
Copy link
Contributor Author

Reminder, that I will need to add the Global Mute Sound button at some point before September.

@zepumph
Copy link
Member

zepumph commented May 23, 2019

This issue is quite stale, likely the bottom bar is looking really good for single screen sims, since we have published a few already. Unassigning myself until work continues for multi-screen sims and my feedback and time is needed.

@terracoda
Copy link
Contributor Author

I will double check what has been implemented and see if anything is missing. True, the bottom with mute sound, keyboard shortcuts, and PhET menu has been working fine for people thus far.

@terracoda
Copy link
Contributor Author

terracoda commented Feb 3, 2021

We have designed the multi-screen sim for Ratio and Proportion.

We can use the sim as a good pattern. The buttons were updated to work well with desktop screen readers and mobile VoiceOver.

Here are screen shots of the final Home Screen, Discover Screen and Create Screen for Ration and Proportion.
The A11y View text shows that when changing screens, focus starts at the top. On the Home Screen, I just happen to have my focus on the first screen button.

Screen Shot 2021-02-03 at 3 17 31 PM

Screen Shot 2021-02-03 at 3 17 50 PM

Screen Shot 2021-02-03 at 3 18 09 PM

@terracoda
Copy link
Contributor Author

Oh this might not be the right issue for the previous comment.

@terracoda
Copy link
Contributor Author

Moving previous comment it #104

@jessegreenberg
Copy link
Contributor

#94 (comment) look great! This issue was also about the navigation bar, is there anything else to do for that or can this issue be closed now?

@terracoda
Copy link
Contributor Author

terracoda commented Feb 8, 2021

And just an FYI, I updated https://github.com/phetsims/joist/blob/master/doc/HomeScreen.md to include Ratio and Proportion as one of the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants