-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y Semantics for bottom bar in single and multi-screen sims #94
Comments
Using Build and Atom as an Example: |
I updated the actual template files. Note added June 20: I am not adding any more examples. The multi-screen sim example is being reviewed. |
Adding links to the template files: |
I have created a Design Pattern for multi-screen sims in joist. I used code from these mock-ups buyt have iterated a little bit. |
Mark down file for the Home Screen is in joist/doc/HomeScreen.md |
@zepumph, I have updated the index.html file in the baa-screens folder. I have put all the sim content on one page, so everything can be seen together. FYI, I put horizontal rules in between sim screen. Note that the code validates with warnings about the multiple H1 elements, and the JS that is supposed to collapse and expand the PhET Menu is not quite right. I'm not sure why it works for one button, but not the other. |
When on git hub, the javascript for the PhET Menu does not work on either PhET Menu button. |
The example in #94 (comment) is updated, and awaiting review by team. |
Reminder, that I will need to add the Global Mute Sound button at some point before September. |
This issue is quite stale, likely the bottom bar is looking really good for single screen sims, since we have published a few already. Unassigning myself until work continues for multi-screen sims and my feedback and time is needed. |
I will double check what has been implemented and see if anything is missing. True, the bottom with mute sound, keyboard shortcuts, and PhET menu has been working fine for people thus far. |
We have designed the multi-screen sim for Ratio and Proportion. We can use the sim as a good pattern. The buttons were updated to work well with desktop screen readers and mobile VoiceOver. Here are screen shots of the final Home Screen, Discover Screen and Create Screen for Ration and Proportion. |
Oh this might not be the right issue for the previous comment. |
Moving previous comment it #104 |
#94 (comment) look great! This issue was also about the navigation bar, is there anything else to do for that or can this issue be closed now? |
And just an FYI, I updated https://github.com/phetsims/joist/blob/master/doc/HomeScreen.md to include Ratio and Proportion as one of the examples. |
See #25 for historical discussion.
In March 6th Keyboard Nav Meeting, we decided to re-structure the bottom bar to better communicate the function/role of the bottom bar and to better communicate access to sim screen buttons in multi-screen sims.
@terracoda will post new HTML here and we can discuss any further code or design changes here.
The text was updated successfully, but these errors were encountered: