Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement keyboard nav for the navigation bar #462

Closed
zepumph opened this issue Nov 7, 2017 · 8 comments
Closed

Implement keyboard nav for the navigation bar #462

zepumph opened this issue Nov 7, 2017 · 8 comments

Comments

@zepumph zepumph self-assigned this Nov 7, 2017
zepumph added a commit that referenced this issue Nov 8, 2017
zepumph added a commit that referenced this issue Nov 8, 2017
zepumph added a commit that referenced this issue Nov 8, 2017
zepumph added a commit that referenced this issue Nov 8, 2017
zepumph added a commit that referenced this issue Nov 8, 2017
zepumph added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Nov 8, 2017
@zepumph
Copy link
Member Author

zepumph commented Nov 8, 2017

I added keyboard nav bigly today to the navigation bar. @terracoda how does this look to you? I like to look at RPAL for a good example since it already has a lot of keyboard nav added. See phettest (phettest.colorado.edu/reactants-products-and-leftovers/reactants-products-and-leftovers-a11y-view.html?brand=phet) or on the dev server (https://www.colorado.edu/physics/phet/dev/html/reactants-products-and-leftovers/1.2.0-dev.3/reactants-products-and-leftovers-a11y-view.html)

Try it out with other sims too!

@terracoda
Copy link
Contributor

terracoda commented Nov 8, 2017

@zepumph, this is looking really good. I do however get leftover ghost focus highlights when going from home screen to sim screen and from sim screen to home screen. I also noticed that in the radio group, focus should go to the selected item in the group, not the first or last item depending on direction of tabbing. See screen shots below with visual examples. All three happen in FF and Safari.

Focus Ghost from Home Screen on Sim Screen
screen shot 2017-11-07 at 21 48 07

Focus Ghost on Home Screen from Sim Screen Navbar
screen shot 2017-11-07 at 21 47 48

Incorrect focus in the radio group
In this example, I am tabbing backward to the radio group with Shift Tab. The focus highlight should go on the radio which is actually selected, not first or last radio in the group.
screen shot 2017-11-07 at 21 57 55

@jessegreenberg
Copy link
Contributor

In phetsims/balloons-and-static-electricity @terracoda mentioned

For single screen sims like Balloons and Static Electricity, the label should not include a reference to Sim Screens, and just be "Sim Resources and Tools".

@zepumph could you please work on that adjustment as part of this issue?

@zepumph
Copy link
Member Author

zepumph commented Nov 14, 2017

Right, thanks for the reminder.

@zepumph
Copy link
Member Author

zepumph commented Nov 17, 2017

@terracoda BASE and other single screen sims should now be restored.

@zepumph
Copy link
Member Author

zepumph commented Nov 18, 2017

Home button blur is fixed above, Weird home screen focus bug is to be addressed in phetsims/chipper#622 and the radio button issue is in phetsims/sun#316

@terracoda until chipper 622 is resolved, please try not to use firefox + a11y view + multiscreen simulations. You can use firefox + multiscreen sims directly still. Anything else for this issue @terracoda?

@terracoda
Copy link
Contributor

phetsims/chipper#622 is resolved.

@jessegreenberg, can I close this issue. It looks like @zepumph implemented my mockups.

@zepumph
Copy link
Member Author

zepumph commented Feb 20, 2018

Closing, bugs will be addressed in their own issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants