-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly re-work general cue to find Keyboard Shortcuts more easily #136
Comments
Oops, sorry, I didn't see duplicate. |
@jessegreenberg and @emily-phet, I can't think of any reason why this small change would be a bad idea. |
Seems fine to me @terracoda. Just throwing out an alternative Is it important that it say "bottom of sim"? "navigation bar" sounds nicer and more accurate to me but I don't feel strongly. |
@jessegreenberg, that is a very reasonable suggestion. I also considered that, but we don't have any content or ARIA role in the sim right now that communicates "navigation bar". How is a blind user to know if the navigation bar is at the beginning or end of the sim? I guess they could rule out beginning because they are at the beginning. Added Iterations to the first list:
Note that multi-screen sims use, "Sim Screens, Resources and Tools", which is why I hesitant to go with the named option. |
Discussed in 3/6/18 keyboard navigation meeting. Together, we came up with this: We will use this for now, but we also discussed restructuring the accessible HTML of the navigation bar to put sim screens in a navigation section and the help dialog and PhET menu in a "resources" region. |
String has been changed. |
@jessegreenberg, when you change and commit the string, can you be sure to change the h2 heading, "Sim Resources and Tools" to "Sim Resources". I just listened on PhET Test and didn't hear the change in either place. Maybe you still need to commit. |
Sure, Ill change the H2 as well, thanks @terracoda. |
OK, both strings were updated. Closing this issue. |
Based on user feedback, visually impaired users may benefit from some instructions on where to actually find the Keyboard Shortcuts button.
Current cue is:
Iterations:
I think example one should do it.
Anythoughts, @emily-phet?
The text was updated successfully, but these errors were encountered: