Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly re-work general cue to find Keyboard Shortcuts more easily #136

Closed
terracoda opened this issue Mar 2, 2018 · 9 comments
Closed
Assignees

Comments

@terracoda
Copy link
Contributor

Based on user feedback, visually impaired users may benefit from some instructions on where to actually find the Keyboard Shortcuts button.

Current cue is:

  • "If needed, checkout keyboard shortcuts for this sim."

Iterations:

  1. "If needed, checkout keyboard shortcuts at bottom of sim."
  2. "If needed, checkout keyboard shortcuts at bottom of sim, under Sim Resources and Tools."

I think example one should do it.

Anythoughts, @emily-phet?

@terracoda
Copy link
Contributor Author

Oops, sorry, I didn't see duplicate.

@terracoda
Copy link
Contributor Author

@jessegreenberg and @emily-phet, I can't think of any reason why this small change would be a bad idea.

@jessegreenberg
Copy link
Contributor

Seems fine to me @terracoda. Just throwing out an alternative
"If needed, check out keyboard shortcuts in the navigation bar."

Is it important that it say "bottom of sim"? "navigation bar" sounds nicer and more accurate to me but I don't feel strongly.

@terracoda
Copy link
Contributor Author

terracoda commented Mar 3, 2018

@jessegreenberg, that is a very reasonable suggestion. I also considered that, but we don't have any content or ARIA role in the sim right now that communicates "navigation bar". How is a blind user to know if the navigation bar is at the beginning or end of the sim? I guess they could rule out beginning because they are at the beginning.

Added Iterations to the first list:

  1. "If needed, checkout keyboard shortcuts at bottom of sim."
  2. "If needed, checkout keyboard shortcuts at bottom of sim, under Sim Resources and Tools."
  3. "If needed, check out keyboard shortcuts in the navigation bar."
  4. "If needed, check out keyboard shortcuts in bottom navigation bar."
  5. "If needed, checkout keyboard shortcuts under Sim Resources and Tools."
  6. "If needed, checkout keyboard shortcuts under Sim Resources and Tools, at bottom of sim."

Note that multi-screen sims use, "Sim Screens, Resources and Tools", which is why I hesitant to go with the named option.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Mar 6, 2018

Discussed in 3/6/18 keyboard navigation meeting. Together, we came up with this:
"If needed, checkout keyboard shortcuts under Sim Resources."

We will use this for now, but we also discussed restructuring the accessible HTML of the navigation bar to put sim screens in a navigation section and the help dialog and PhET menu in a "resources" region.

@jessegreenberg
Copy link
Contributor

String has been changed.

@terracoda
Copy link
Contributor Author

@jessegreenberg, when you change and commit the string, can you be sure to change the h2 heading, "Sim Resources and Tools" to "Sim Resources".

I just listened on PhET Test and didn't hear the change in either place. Maybe you still need to commit.

@jessegreenberg
Copy link
Contributor

Sure, Ill change the H2 as well, thanks @terracoda.

@jessegreenberg
Copy link
Contributor

OK, both strings were updated. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants