Let cargo decide when to upgrade #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published as v0.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cargo installcommand was not able to update installed binaries 4 years ago. So we needed to use some hacks to detect available updates manually and then use--forceto reinstall the newer versions. Apparently this code has some issues with ordering versions numbers, as reported in #1.While we could use the
semvercrate to get the correct order, we can also use the "install-update" feature of cargo itself, which was stabilized in Rust 1.41. Using this feature, this PR is able to vastly simlify the crate. We now just parse thecargo install --listoutput to detect the installed crates and then pass each of them tocargo install. Thecargo installcommand will then figure out whether do upgrade or not itself.Fixes #1.