Skip to content

Commit

Permalink
fix: job retry resource and queue naming (#4099)
Browse files Browse the repository at this point in the history
## Fixes
- resource incorrect named (copy / paste)
- typo in queue name for rety

---------

Co-authored-by: forest-pr|bot <forest-pr[bot]@users.noreply.github.com>
  • Loading branch information
npalm and forest-pr[bot] authored Aug 27, 2024
1 parent 1ad118b commit 4344f18
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion modules/runners/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ yarn run dist
| [aws_iam_role_policy.describe_tags](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.dist_bucket](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.ec2](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.job_retry_sqs_publish](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.runner_session_manager_aws_managed](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.scale_down](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.scale_down_logging](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
Expand All @@ -100,7 +101,6 @@ yarn run dist
| [aws_iam_role_policy.ssm_housekeeper_logging](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.ssm_housekeeper_xray](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.ssm_parameters](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy.webhook_workflow_job_sqs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy) | resource |
| [aws_iam_role_policy_attachment.ami_id_ssm_parameter_read](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.managed_policies](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_iam_role_policy_attachment.scale_down_vpc_execution_role](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
Expand Down
2 changes: 1 addition & 1 deletion modules/runners/job-retry/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ resource "aws_sqs_queue_policy" "job_retry_check_queue_policy" {
}

resource "aws_sqs_queue" "job_retry_check_queue" {
name = "${var.config.prefix}-job-retrys"
name = "${var.config.prefix}-job-retry"
visibility_timeout_seconds = local.config.timeout

sqs_managed_sse_enabled = var.config.queue_encryption.sqs_managed_sse_enabled
Expand Down
2 changes: 1 addition & 1 deletion modules/runners/scale-up.tf
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ resource "aws_iam_role_policy" "scale_up_xray" {
role = aws_iam_role.scale_up.name
}

resource "aws_iam_role_policy" "webhook_workflow_job_sqs" {
resource "aws_iam_role_policy" "job_retry_sqs_publish" {
count = local.job_retry_enabled ? 1 : 0
name = "publish-retry-check-sqs-policy"
role = aws_iam_role.scale_up.name
Expand Down

0 comments on commit 4344f18

Please sign in to comment.