Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 Release Missing Some Of the Included Notes #2822

Closed
Kyrluckechuck opened this issue Dec 29, 2022 · 3 comments
Closed

v2.0.0 Release Missing Some Of the Included Notes #2822

Kyrluckechuck opened this issue Dec 29, 2022 · 3 comments

Comments

@Kyrluckechuck
Copy link

In the release notes for https://github.com/philips-labs/terraform-aws-github-runner/releases/tag/v2.0.0, it indicates that #2809 should have been included in the v2.0.0 tag / release.

I can see it was merged into next, but from what I can tell it's not actually in the v2.0.0 release, and it makes me worry that there may have been other commits that were accidentally dropped, too? Worst case this is just an error report for the below two variables/PR 2809:

For example, if you check out this tag and search the repo looking for enable_fifo_build_queue or enable_runner_workflow_job_labels_check_all do not show any results.

@npalm
Copy link
Member

npalm commented Dec 29, 2022

will check tomorrow

@npalm
Copy link
Member

npalm commented Dec 29, 2022

Quick check, and I think something went wrong indeed with this PR. Other changes are fine. Will apply a fix tomorrow. Thanks for the notice

@npalm
Copy link
Member

npalm commented Dec 30, 2022

@Kyrluckechuck can you have a quick look on PR #2822 ?

@npalm npalm closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants