Only allow tagging and termination of runner instances #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpalomaki
changed the title
|
Looks good, will run a check later this week. Thanks for creating the PR |
npalm
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Scaling lambda IAM roles permit tagging and termination of arbitrary EC2 instances, which is not desirable.
Description of the Change
Harden scaling lambda IAM policies to ensure we can only tag and terminate runner instances by:
ec2:CreateTagsto just instance creationec2:DeleteTags(seems to be unused anyways)ec2:TerminateInstancesfor only tagged runner instancesAlternate Designs
N/A
Possible Drawbacks
N/A
Verification Process
This was tested by deploying the runner stack to an AWS account, and having the lambdas scale runners up and down, both of which seem to have succeeded without errors (looking at lambda logs and EC2 instance states).
Release Notes