refactor: use optional in variable block_device_mappings #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpalomaki
changed the title
17 tasks
npalm
requested changes
Nov 16, 2022
|
Please can you rebase the PR, or maybe easier re-created. I rebased earlier today next with develop. (sorry) / thanks any ways! |
|
@npalm PR recreated in-place. Untested atm though. |
npalm
approved these changes
Nov 17, 2022
npalm
pushed a commit
that referenced
this pull request
Nov 17, 2022
refactor: use optiona for variable block_device_mappings
npalm
pushed a commit
that referenced
this pull request
Dec 13, 2022
refactor: use optiona for variable block_device_mappings
npalm
pushed a commit
that referenced
this pull request
Dec 13, 2022
refactor: use optiona for variable block_device_mappings
npalm
pushed a commit
that referenced
this pull request
Dec 28, 2022
refactor: use optiona for variable block_device_mappings
npalm
pushed a commit
that referenced
this pull request
Dec 28, 2022
refactor: use optiona for variable block_device_mappings
npalm
pushed a commit
that referenced
this pull request
Dec 28, 2022
refactor: use optiona for variable block_device_mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make usage a little more straightforward when one only wants to override some attributes, e.g volume size