Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding missing input lambda vpc vars to syncer module #2701

Merged
merged 2 commits into from
Nov 30, 2022
Merged

fix: Adding missing input lambda vpc vars to syncer module #2701

merged 2 commits into from
Nov 30, 2022

Conversation

jsalcedo1987
Copy link
Contributor

The variables lambda_subnet_ids and lambda_security_group_ids are declared in the syncer module but are not passed from the root main.tf, so the syncer lambda is created without the security group ids and subnets.

@npalm npalm self-requested a review November 30, 2022 16:35
@npalm npalm changed the title fix: adding missing input vars to syncer module fix: Adding missing input lambda vpc vars to syncer module Nov 30, 2022
npalm
npalm reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsalcedo1987 thx!

@npalm npalm merged commit c91a96b into philips-labs:develop Nov 30, 2022
forest-releaser bot pushed a commit that referenced this pull request Nov 30, 2022
@semantic-release-bot
chore(release): 1.17.0 [skip ci]
75e15a6 
## [1.17.0](v1.16.1...v1.17.0) (2022-11-30)

### Features

* **runners:** Namespace `Application` tag ([#2182](#2182)) ([a1a47a4](a1a47a4))

### Bug Fixes

* Adding missing input lambda vpc vars to syncer module ([#2701](#2701)) ([c91a96b](c91a96b))
@forest-releaser forest-releaser bot mentioned this pull request Dec 28, 2022
Closed
@forest-releaser forest-releaser bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsalcedo1987 @npalm