Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added permissions for lambda to attach lambda to the VPC. #2734

Merged
merged 4 commits into from
Dec 9, 2022
Merged

fix: added permissions for lambda to attach lambda to the VPC. #2734

merged 4 commits into from
Dec 9, 2022

Conversation

GuptaNavdeep1983
Copy link
Contributor

@GuptaNavdeep1983 GuptaNavdeep1983 commented Dec 8, 2022 •
edited
Loading

#2732
Updated the code to add permissions for lambda required in case the lambda needs to be attached to the VPC. The issue was reported only for runner_syncer lambda but this issue will be seen for all lambda functions which needs to be attached to VPC.

npalm
npalm requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuptaNavdeep1983 thanks looks good, one small suggestion

modules/runner-binaries-syncer/runner-binaries-syncer.tf Outdated Show resolved Hide resolved
npalm
npalm approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @navdeepg2021 looks good

@npalm
Copy link
Member

npalm commented Dec 9, 2022

close #2732

@GuptaNavdeep1983 GuptaNavdeep1983 merged commit fb72ee8 into develop Dec 9, 2022
@GuptaNavdeep1983 GuptaNavdeep1983 deleted the fix/2732 branch December 9, 2022 12:27
forest-releaser bot pushed a commit that referenced this pull request Dec 9, 2022
@semantic-release-bot
chore(release): 1.18.0 [skip ci]
7d79ec0 
## [1.18.0](v1.17.0...v1.18.0) (2022-12-09)

### Features

* Support price-capacity-optimized strategy ([#2718](#2718)) ([ef08afb](ef08afb))

### Bug Fixes

* added permissions for lambda to attach lambda to the VPC. ([#2734](#2734)) ([fb72ee8](fb72ee8))
@forest-releaser forest-releaser bot mentioned this pull request Dec 28, 2022
Closed
@forest-releaser forest-releaser bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaNavdeep1983 @npalm @navdeepg2021