Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base setup for scaling and cleanup lambdas #3

Merged
merged 40 commits into from
May 13, 2020
Merged

Conversation

gertjanmaas
Copy link
Collaborator

@gertjanmaas gertjanmaas commented Apr 29, 2020

Adds lambdas for creating and destroying runners

@github-actions
Copy link
Contributor

terraform validate Failed


Error: Error in function call

  on modules/agent/webhook.tf line 42, in resource "aws_lambda_function" "webhook":
  42:   source_code_hash = filebase64sha256("${path.module}/lambdas/webhook/webhook.zip")
    |----------------
    | path.module is "modules/agent"

Call to function "filebase64sha256" failed: no file exists at
modules/agent/lambdas/webhook/webhook.zip.


Error: Error in function call

  on modules/runners/scale-runners-lambda.tf line 3, in resource "aws_lambda_function" "scale_runners_lambda":
   3:   source_code_hash = filebase64sha256("${path.module}/lambdas/scale-runners/scale-runners.zip")
    |----------------
    | path.module is "modules/runners"

Call to function "filebase64sha256" failed: no file exists at
modules/runners/lambdas/scale-runners/scale-runners.zip.

Workflow: Terraform root module checks, Action: hashicorpterraform-github-actions3, Working Directory: ., Workspace: default

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2020

terraform validate Failed


Error: Duplicate module call

  on main.tf line 45:
  45: module "agent" {

An module call named "agent" was already defined at main.tf:35,1-15. Module
calls must have unique names within a module.

Workflow: Terraform root module checks, Action: hashicorpterraform-github-actions3, Working Directory: ., Workspace: default

npalm added 2 commits May 6, 2020 20:55
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2020

terraform validate Failed


Error: Duplicate module call

  on main.tf line 45:
  45: module "agent" {

An module call named "agent" was already defined at main.tf:35,1-15. Module
calls must have unique names within a module.

Workflow: Terraform root module checks, Action: hashicorpterraform-github-actions3, Working Directory: ., Workspace: default

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2020

terraform validate Failed


Error: Missing required argument

  on main.tf line 36, in module "runners":
  36: module "runners" {

The argument "github_app_client_id" is required, but no definition was found.


Error: Missing required argument

  on main.tf line 36, in module "runners":
  36: module "runners" {

The argument "github_app_client_secret" is required, but no definition was
found.


Error: Missing required argument

  on main.tf line 36, in module "runners":
  36: module "runners" {

The argument "sqs" is required, but no definition was found.


Error: Missing required argument

  on main.tf line 36, in module "runners":
  36: module "runners" {

The argument "github_app_key_base64" is required, but no definition was found.


Error: Missing required argument

  on main.tf line 36, in module "runners":
  36: module "runners" {

The argument "enable_organization_runners" is required, but no definition was
found.


Error: Missing required argument

  on main.tf line 36, in module "runners":
  36: module "runners" {

The argument "github_app_id" is required, but no definition was found.

Workflow: Terraform root module checks, Action: hashicorpterraform-github-actions3, Working Directory: ., Workspace: default

@npalm
Copy link
Member

npalm commented May 12, 2020

TODO
#12 #11

@npalm
Copy link
Member

npalm commented May 13, 2020

@gertjanmaas shall we merge back?

@npalm npalm marked this pull request as ready for review May 13, 2020 10:45
@npalm npalm merged commit 18493a0 into master May 13, 2020
@npalm npalm deleted the feature/runners-lambdas branch May 13, 2020 17:04
npalm added a commit that referenced this pull request Aug 5, 2021
# This is the 1st commit message:

Rebase

# This is the commit message #2:

fix: terraform error

# This is the commit message #3:

fix: terraform error

# This is the commit message #4:

fix: test and linter

# This is the commit message #5:

runner labels can be a subset

# This is the commit message #6:

runner labels can be a subset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants