feat(images): automatically find latest GitHub Runner version when building images #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautamg795
changed the title
gautamg795
force-pushed
the
runner-version
branch
from
06cbfee to
f48d82c
Compare
npalm
reviewed
Mar 30, 2023
There was a problem hiding this comment.
@gautamg795 looks good to me. Please go ahead with updating the other image examples
|
fyi @npalm, I've made the requested updates and this should be ready for review |
npalm
requested changes
Apr 18, 2023
Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
npalm
approved these changes
Apr 19, 2023
npalm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires using a newer version of
packerto get thehttpdata source, but this now allows an operator to omit therunner_versionvariable and still ensure that the built image is using the newest runner, removing the need for an autoupdate when the runner starts up.Previous behavior of overriding the variable when desired is maintained.