Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Next major release #3552

Merged
merged 8 commits into from
Oct 27, 2023
Merged

chore: Next major release #3552

merged 8 commits into from
Oct 27, 2023

Conversation

npalm
Copy link
Member

@npalm npalm commented Oct 19, 2023

🚀 Upcoming release 5.0.0

Breaking changes

Linux version updated to Amazon Linux 2023

PR: #3437

The default Linux version in the module is updated to Amazon Linux 2023.

Migrations

  • Custom user_data or pre / post install scripts could require an update.
  • Pipelines relying on the OS could require an update.
  • Migration can be avoided by providing your own AMI and user_data script, check the ubuntu example for inspiration.

Runner Labels

PR: #3410

Change of variable type and add option to declare labels for multi runner twice.

Migrations

  • Variables runner_extra_labels changed from type string to string[]. Update runner_extra_labels from "label1,label2" to ["label1","label2"]
  • For the multi-runners labels are in most cases defined twice. For the webhook in the labelMatchers and for the runner in runner_config.runner_extra_labels. By default we merge the labels if runner_extra_labels is not set. In most cases you can just remove runner_extra_labels.

close #3553

@npalm npalm mentioned this pull request Oct 26, 2023
@npalm
Copy link
Member Author

npalm commented Oct 26, 2023

@koendelaat @navdeepg2021 this PR is ready. Any comments / suggestions before I merge?

@npalm
Copy link
Member Author

npalm commented Oct 26, 2023

⚠️ THIS PR NEEDS TO BE MERGED WITH MERGE COMMIT ⚠️

ScottGuymer
ScottGuymer previously approved these changes Oct 26, 2023
npalm and others added 8 commits October 26, 2023 10:03
…MI (#3437)

Replaces Amazon lLnux 2 (default) by Amazon Linux 2023. Impact for anyone relying on the default setup provided by the module.

---------

Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
Change variables `runner_labels` and `runner_extra_labels` to type:
`list[string]` to better represent the content

Additionally:
- [x] Automatic determine runner labels for multi runner based on label
matchers
- [x] Enable Terraform linting on all modules, including naming
conventions
- [x] Enable check annotations for linting errors
- [x] Fix existing linting errors
- [ ] Apply naming conventions within objects (not supported by
[TFLint](terraform-linters/tflint#1310))


This PR is based on #3143 creaed by @koendelaat but now via a dedicate
branch in this repository.

---------

Co-authored-by: Koen de Laat <koen.de.laat@philips.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
koendelaat
koendelaat previously approved these changes Oct 26, 2023
@npalm npalm dismissed stale reviews from GuptaNavdeep1983, koendelaat, and ScottGuymer October 27, 2023 07:53

The merge-base changed after approval.

ScottGuymer
ScottGuymer previously approved these changes Oct 27, 2023
@npalm npalm dismissed ScottGuymer’s stale review October 27, 2023 09:15

The merge-base changed after approval.

ScottGuymer
ScottGuymer previously approved these changes Oct 27, 2023
@npalm npalm dismissed ScottGuymer’s stale review October 27, 2023 13:03

The merge-base changed after approval.

@npalm npalm dismissed GuptaNavdeep1983’s stale review October 27, 2023 13:32

The merge-base changed after approval.

@npalm npalm removed the request for review from koendelaat October 27, 2023 13:35
@npalm npalm merged commit 870212c into main Oct 27, 2023
40 checks passed
@npalm npalm deleted the next branch October 27, 2023 13:37
npalm pushed a commit that referenced this pull request Oct 27, 2023
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](v4.7.0...v5.0.0)
(2023-10-27)

### Migration directions

See
[PR](#3552)
for migration directions.

### ⚠ BREAKING CHANGES

* remove depcrecated input and output variables
([#3567](#3567))
* Change runner labels to list[string] and apply TFLint
([#3410](#3410))
* replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI
([#3437](#3437))

### Features

* replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI
([#3437](#3437))
([35219f5](35219f5))


### Bug Fixes

* Change runner labels to list[string] and apply TFLint
([#3410](#3410))
([0b398f2](0b398f2))
* remove depcrecated input and output variables
([#3567](#3567))
([89c8575](89c8575))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 5.0.0
5 participants