-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding github URL to config.cmd #3842
Conversation
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
Hello, I am running into this issue, when could this be available in a release? |
I was just looking at this more closely and since multiple repos can use the runner would it be better if the webhook lambda stored the repo URL (from the webhook payload) into SSM for the runner to pick-up when running the user_data script? |
+1 I am seeing this issue as well |
I actually ended up fixing this by using a custom image and modifying the start-runner script by removing the
From what I could gather, a similar fix went into the linux start-runner script but the Windows one was never fixed. Adding the |
@dhlaurap can you confirm which version of the github runner are you using please ?
this project is great but seems to suffer of a lack of testability (or i haven't found it), can somebody give tricks on how to quickly test the AMI without need to deploy the whole lambdas ? for instance |
Just confirmed it is currently running with the github runner version Could it be that your |
#3737 This adds the variable gh_url, creates a SSM parameter containing the value from gh_url, and passes in the value of gh_url to the config.cmd call.