Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add windows headers to clang-cl regression test #551

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

richardapeters
Copy link
Contributor

@richardapeters richardapeters commented Aug 29, 2024

Pull Request

Description of changes

This PR adds several Windows SDK headers to the Windows cross compilation test with clang-cl. Making sure that the SDK is touched when doing the compilation.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@richardapeters richardapeters requested a review from a team as a code owner August 29, 2024 09:22
Copy link

sonarcloud bot commented Aug 29, 2024

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR. We really appreciate it!

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:3f7b3c3949d1a8f0e075f6e6e936b636ce949ba56479e62ba6a0371b3da3802c

OS/Platform Previous Size Current Size Delta
linux/amd64 432.86M 433.15M 304.42K (+0.07%)
linux/arm64 572.09M 572.36M 278.83K (+0.05%)

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.09s
✅ DOCKERFILE hadolint 2 0 0.47s
✅ JSON prettier 15 0 0 0.63s
✅ JSON v8r 14 0 18.27s
✅ MARKDOWN markdownlint 8 0 0 0.98s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.24s
✅ REPOSITORY checkov yes no 14.67s
✅ REPOSITORY gitleaks yes no 0.41s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.32s
✅ REPOSITORY secretlint yes no 1.19s
✅ REPOSITORY trivy yes no 5.59s
✅ REPOSITORY trivy-sbom yes no 0.87s
✅ REPOSITORY trufflehog yes no 3.27s
✅ SPELL lychee 54 0 0.93s
✅ YAML prettier 21 0 0 0.97s
✅ YAML v8r 21 0 12.61s
✅ YAML yamllint 21 0 0.36s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:7f8c1d93c64bdb74e89e75d455aa1f2e71a7ab912183b04a7cc4578ee672ee5b

OS/Platform Previous Size Current Size Delta
linux/amd64 640.74M 641.13M 395.64K (+0.06%)
linux/arm64 633.10M 633.48M 384.88K (+0.06%)

Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   53s ⏱️ +3s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1a50f05. ± Comparison against base commit 2c207fc.

@rjaegers rjaegers changed the title ci: add windows headers to clang-cl regression test test: add windows headers to clang-cl regression test Aug 29, 2024
@rjaegers rjaegers added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 24f07c0 Aug 29, 2024
24 checks passed
@rjaegers rjaegers deleted the feature/add-win-test branch August 29, 2024 10:36
Copy link
Contributor

Pull Request Report (#551)

Static measures

Description Value
Number of added lines 3
Number of deleted lines 0
Number of changed files 1
Number of commits 1
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 1.2 Hours
Time that was spend on the branch before the PR was created 41 Sec
Time that was spend on the branch before the PR was merged 1.2 Hours
Time to merge after last review 4.3 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 18.3 Min
Total time spend in last status check run on PR 1.1 Hours

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.1.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants