Incorrect mask and fix warning #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value of `evt->response_type` comes from X11 server and at least in Xorg it's not constant but depends on number of loaded extensions https://gitlab.freedesktop.org/xorg/xserver/-/blob/21b3dad2380639573c251d95910bcb644049ee5f/mi/miinitext.c#L110 and a number of arguments each loaded extension takes. When randr module is loaded https://gitlab.freedesktop.org/xorg/xserver/-/blob/d6c02ffd9c910637f6b3b7249507998e9e45f93c/randr/randr.c#L439 `REventBase` is calculated. On Debian 12 its value is 89 so the method _incidentally_ works as 89 & 1 is 1 but on my Slackware system it's value is 88 and since 88 & 1 isn't 1 the method doesn't work. Fixes phillipberndt#375
gcc and clang report warnings due to -Wwrite-strings:
$ docker run -it --rm -v "$PWD":/workspace -w /workspace gcc sh -c 'apt-get update &&
apt-get -y install libxcb1-dev libxcb-randr0-dev &&
make'
(...)
cc -pipe -o2 -Wstrict-overflow=5 -fstack-protector-all -W -Wall -Wextra -Wbad-function-cast -Wcast-align -Wcast-qual -Wconversion -Wfloat-equal -Wformat-y2k -Winit-self -Winline -Winvalid-pch -Wmissing-declarations -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wnormalized=nfc -Wold-style-definition -Woverlength-strings -Wpacked -Wpadded -Wpointer-arith -Wredundant-decls -Wshadow -Wsign-compare -Wstack-protector -Wstrict-aliasing=2 -Wstrict-prototypes -Wundef -Wunsafe-loop-optimizations -Wvolatile-register-var -Wwrite-strings "-DAUTORANDR_PATH=\"\"" -o autorandr-launcher autorandr_launcher.c -lxcb -lxcb-randr
autorandr_launcher.c: In function 'ar_launch':
<command-line>: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
autorandr_launcher.c:47:41: note: in expansion of macro 'AUTORANDR_PATH'
47 | static char *argv[] = { AUTORANDR_PATH, "--change", "--default", "default", NULL};
| ^~~~~~~~~~~~~~
autorandr_launcher.c:47:57: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
47 | static char *argv[] = { AUTORANDR_PATH, "--change", "--default", "default", NULL};
| ^~~~~~~~~~
autorandr_launcher.c:47:69: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
47 | static char *argv[] = { AUTORANDR_PATH, "--change", "--default", "default", NULL};
| ^~~~~~~~~~~
autorandr_launcher.c:47:82: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
47 | static char *argv[] = { AUTORANDR_PATH, "--change", "--default", "default", NULL};
| ^~~~~~~~~
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375