Oracle #206
Merged
Oracle #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhu17 Hi, sorry for the delay, I will look at PR soon |
|
Hi Serge, np, just when you have time.
Serge K ***@***.***> 于2022年3月17日周四 01:25写道：
… @bhu17 <https://github.com/bhu17> Hi, sorry for the delay, I will look at
PR soon
—
Reply to this email directly, view it on GitHub
<#206 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFZ7CR3U6VQS34HZ4KXSOBLVAJ3YLANCNFSM5PIV6LZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@bhu17 Can you set up docker compose https://github.com/phnx47/dapper-repositories/blob/master/docker-compose.yml ? Something wrong with Oracle in compose. I want to run tests locally and GitHub Actions. |
|
@bhu17 You need fix tests in |
You can test it directly use docker with the comment I have wrote in cmd or shell to start an oracle instance and run all the test locally. that is what I have done. I forget to set up the docker compose for it. I will try to fix this week. seems your docker compose need enviroment block for oracle part. |
|
@bhu17 No worries. I moved from AppVeyor to GitHub Actions with docker compose but need your help with Oracle |
|
<!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
***@***.***";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
***@***.***";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:DengXian;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
-->Hi Serge, sorry for the delay. I have tested your docker-compose under Windows, it works fine, doesnt need any fix. After execute docker-compose up I can connect to it with Oracle SQL developer. Username and pwd can be found here: https://github.com/phnx47/dapper-repositories/blob/master/test/MicroOrm.Dapper.Repositories.Tests/DatabaseFixture/Oracle12cDatabaseFixture.cs#:~:text=%22DATA%20SOURCE%3D(DESCRIPTION%3D(ADDRESS%3D(PROTOCOL%3DTCP)(HOST%3Dlocalhost)(PORT%3D1521))(CONNECT_DATA%3D(SERVICE_NAME%3Dxe)))%3BUser%20Id%3Dsystem%3BPassword%3Doracle%22)%3B If you have troubles under Linux, plz send me some error message since I didnot have tested it under Linux. BestBo From: Serge KSent: 2022年3月27日 13:50To: phnx47/dapper-repositoriesCc: bhu17; MentionSubject: Re: [phnx47/dapper-repositories] Oracle (PR ***@***.*** Can you set up docker compose https://github.com/phnx47/dapper-repositories/blob/master/docker-compose.yml ? Something wrong with Oracle in compose. I want to run tests locally and GitHub Actions.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
<!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
***@***.***";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
***@***.***";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:DengXian;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
code
{mso-style-priority:99;
font-family:SimSun;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
-->Hi, All Tests in this files can be succefully executed. You find Details in attachments. BestBo Sent from Mail for Windows From: Serge KSent: 2022年3月27日 13:59To: phnx47/dapper-repositoriesCc: bhu17; MentionSubject: Re: [phnx47/dapper-repositories] Oracle (PR ***@***.*** You need fix tests in Oracle12cSqlGeneratorTests—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@bhu17 Can you raise new PR? This was merged already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Oracle12c with test cases.