remove default value on boolean node, add new dataset on ExtractorTest

php-etl · May 27, 2024 · f4e47df · f4e47df
1 parent 320bdd5
commit f4e47df
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 5 deletions.
diff --git a/src/Builder/Capacity/Lookup/All.php b/src/Builder/Capacity/Lookup/All.php
@@ -15,10 +15,6 @@ final class All implements Builder
     private ?Node\Expr $code = null;
     private string $type = '';
 
-    public function __construct()
-    {
-    }
-
     public function withEndpoint(Node\Expr|Node\Identifier $endpoint): self
     {
         $this->endpoint = $endpoint;

diff --git a/src/Configuration/Extractor.php b/src/Configuration/Extractor.php
@@ -197,6 +197,14 @@ public function getConfigTreeBuilder(): Config\Definition\Builder\TreeBuilder
                     && \in_array($data['type'], ['referenceEntityAttributeOption'], true))
                 ->thenInvalid('The reference_entity option should be used with the "referenceEntityAttributeOption" endpoint.')
             ->end()
+            ->validate()
+                ->ifTrue(fn ($data) => \array_key_exists('with_enriched_attributes', $data) && \array_key_exists('type', $data) && 'all' !== $data['method'] && \in_array($data['type'], ['category'], true))
+                ->thenInvalid('The with_enriched_attributes option should only be used with the "category" endpoint.')
+            ->end()
+            ->validate()
+                ->ifTrue(fn ($data) => \array_key_exists('with_enriched_attributes', $data) && \array_key_exists('method', $data) && 'all' !== $data['method'])
+                ->thenInvalid('The with_enriched_attributes option should only be used with the "all" method.')
+            ->end()
             ->children()
                 ->scalarNode('type')
                     ->isRequired()
@@ -239,7 +247,6 @@ public function getConfigTreeBuilder(): Config\Definition\Builder\TreeBuilder
                     ->end()
                 ->end()
                 ->booleanNode('with_enriched_attributes')
-                    ->defaultFalse()
                     ->validate()
                         ->ifTrue(isExpression())
                         ->then(asExpression())

diff --git a/tests/functional/Configuration/ExtractorTest.php b/tests/functional/Configuration/ExtractorTest.php
@@ -82,6 +82,20 @@ public static function validDataProvider(): iterable
                 'search' => [],
             ],
         ];
+        yield [
+            'config' => [
+                'method' => 'all',
+                'type' => 'category',
+                'search' => [],
+                'with_enriched_attributes' => true,
+            ],
+            'expected' => [
+                'method' => 'all',
+                'type' => 'category',
+                'search' => [],
+                'with_enriched_attributes' => true,
+            ],
+        ];
     }
 
     #[\PHPUnit\Framework\Attributes\DataProvider('validDataProvider')]