Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Throwable on ContainerExceptionInterface #31

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

moufmouf
Copy link
Contributor

@moufmouf moufmouf commented Mar 5, 2021

We added Throwable on ContainerExceptionInterface because we thought this would not introduce any breaking changes.
Alas, some classes implementing the ContainerExceptionInterface are already adding the Throwable interface,
and PHP won't let us add the interface twice.

This problem occurs with PHP 7.2 and PHP 7.3 only.

See #30

We added Throwable on ContainerExceptionInterface because we thought this would not introduce any breaking changes.
Alas, some classes implementing the ContainerExceptionInterface are already adding the Throwable interface,
and PHP won't let us add the interface twice.

This problem occurs with PHP 7.2 and PHP 7.3 only.
@moufmouf
Copy link
Contributor Author

moufmouf commented Mar 5, 2021

Note: DO NOT MERGE THIS IN MASTER! (master is the 2.0 branch)
We need to create another branch from the 1.1.0 tag and merge this https://github.com/moufmouf/container/tree/fix/remove_throwable into the new branch.
Then, tag from the new branch.

@moufmouf moufmouf changed the base branch from master to 1.1 March 5, 2021 17:18
@moufmouf
Copy link
Contributor Author

moufmouf commented Mar 5, 2021

Ok, I created a 1.1 branch in the psr/container repository and the PR is now correctly targetting this new 1.1 branch.
We can create the tag from this branch.

I'm not sure if we need to delete the branch later or if we keep the branch open for a future 1.1.2 (see #30 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants