Bring back support for PHP 5.3 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Parallel Lint supports PHP 5.3 again since [PR 51](php-parallel-lint/PHP-Parallel-Lint#51), it would be helpful for the Highlighter repo to also support PHP 5.3. This restores the PHP 5.3 minimum version along the same lines as before the version drop in 02b6aa6 The PHP 5.3.2 minimum is in-line with the PHP Console Color minimum version for PHP 5.3. Includes: * Enabling a build against PHP 5.3 in the GH Actions workflow. * Adjusting the `testVersion` for the PHPCompatibility checks to `5.3-` (5.3 and higher).
jrfnl
force-pushed
the
feature/support-php-5.3
branch
from
cdd3241 to
14c2988
Compare
|
Thank you, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Parallel Lint supports PHP 5.3 again since PR 51, it would be helpful for the Highlighter repo to also support PHP 5.3.
Now PHP-Console-Color 1.0.1 has been released, support for PHP 5.3 can be restored for this repo as well.
This restores the PHP 5.3 minimum version along the same lines as before the version drop in 02b6aa6
The PHP 5.3.2 minimum is in-line with the PHP Console Color minimum version for PHP 5.3.
Includes:
testVersionfor the PHPCompatibility checks to5.3-(5.3 and higher).